-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TSconfig to allow file structure for surveys #1001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @benjackwhite! 👋 |
Size Change: +1.06 kB (0%) Total Size: 778 kB
ℹ️ View Unchanged
|
liyiy
added a commit
that referenced
this pull request
Feb 15, 2024
* setup wip * support new components in tests and add event listeners * multiple choice and multiple question surveys * connect multiple questions surveys and type fixes * convert feedback widget * working open choice option * clean up unit tests * fix confirmation box close * missing lock file? * fix test * test * test flakey test * change order of capture wait * test * cypress leaving too quickly * flakey test * final fix?? * clean up useRef code * add todos and address rating question type comments * remove unused auto-text-color class * collapse else ifs * singular display state for surveys * fix display status state * fix test * test * this one test.... * fix: TSconfig to allow file structure for surveys (#1001) * Refactor * Fix * fix? * fix? * option 2 * refactor and fixes --------- Co-authored-by: Neil Kakkar <[email protected]> Co-authored-by: Li Yi <[email protected]> * fix check mark color on white backgrounds * test * fix weird cached state test * fix open ended answer submit bug * split up the survey shown and dismissed event test * feat(surveys): render surveys preview method (#1020) * Refactor * Fix * fix? * fix? * option 2 * refactor and fixes * wip * only export preview render * read only mode for preview * fix import * add question index preview state * refactor auto text color * remove right css for preview * border radius fix * remove comments * move render into loader-surveys * add test and undo optional param * type fixes --------- Co-authored-by: Ben White <[email protected]> Co-authored-by: Neil Kakkar <[email protected]> --------- Co-authored-by: Ben White <[email protected]> Co-authored-by: Neil Kakkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Let's see if it all builds as it should...
Checklist