Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TSconfig to allow file structure for surveys #1001

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Feb 6, 2024

Changes

Let's see if it all builds as it should...

Checklist

@posthog-bot
Copy link
Collaborator

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@benjackwhite benjackwhite changed the base branch from main to preact-surveys-components February 6, 2024 17:25
Copy link

github-actions bot commented Feb 6, 2024

Size Change: +1.06 kB (0%)

Total Size: 778 kB

Filename Size Change
dist/surveys.js 53.6 kB +1.06 kB (+2%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 181 kB
dist/array.js 122 kB
dist/es.js 123 kB
dist/exception-autocapture.js 12.1 kB
dist/module.js 123 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 58.6 kB

compressed-size-action

@liyiy liyiy marked this pull request as ready for review February 7, 2024 23:55
@liyiy liyiy requested review from Twixes and neilkakkar February 7, 2024 23:55
@liyiy liyiy merged commit 839e9cb into preact-surveys-components Feb 8, 2024
10 of 11 checks passed
@liyiy liyiy deleted the fix/tsconfig branch February 8, 2024 19:36
liyiy added a commit that referenced this pull request Feb 15, 2024
* setup wip

* support new components in tests and add event listeners

* multiple choice and multiple question surveys

* connect multiple questions surveys and type fixes

* convert feedback widget

* working open choice option

* clean up unit tests

* fix confirmation box close

* missing lock file?

* fix test

* test

* test flakey test

* change order of capture wait

* test

* cypress leaving too quickly

* flakey test

* final fix??

* clean up useRef code

* add todos and address rating question type comments

* remove unused auto-text-color class

* collapse else ifs

* singular display state for surveys

* fix display status state

* fix test

* test

* this one test....

* fix: TSconfig to allow file structure for surveys (#1001)

* Refactor

* Fix

* fix?

* fix?

* option 2

* refactor and fixes

---------

Co-authored-by: Neil Kakkar <[email protected]>
Co-authored-by: Li Yi <[email protected]>

* fix check mark color on white backgrounds

* test

* fix weird cached state test

* fix open ended answer submit bug

* split up the survey shown and dismissed event test

* feat(surveys): render surveys preview method (#1020)

* Refactor

* Fix

* fix?

* fix?

* option 2

* refactor and fixes

* wip

* only export preview render

* read only mode for preview

* fix import

* add question index preview state

* refactor auto text color

* remove right css for preview

* border radius fix

* remove comments

* move render into loader-surveys

* add test and undo optional param

* type fixes

---------

Co-authored-by: Ben White <[email protected]>
Co-authored-by: Neil Kakkar <[email protected]>

---------

Co-authored-by: Ben White <[email protected]>
Co-authored-by: Neil Kakkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants